Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hollow Knight: Clean outdated slot data code and comments #3988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hollow Knight: Clean outdated slot data code and comments #3988

wants to merge 1 commit into from
+5 −15

Conversation

BadMagic100
Copy link
Collaborator

@BadMagic100 BadMagic100 commented Sep 23, 2024 •
edited
Loading

What is this fixing or adding?

Cleans up some outdated stuff in the slot data which was discovered due to #3971. Specifically,

  • Updates a comment to be clear about its scope and correct in its content
  • Removes very old backwards compatibility slot data - clients that old will not work with new generations and newer clients already don't read them anymore.
  • Removes an unnecessary int cast
  • Move a questionable else block into the related try block

How was this tested?

Tested the client can connect and read slot data correctly before and after the change

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 23, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, still generates just fine. It is kind of weird to me that there's a try/except exclusively for PlandoCharmCosts but it was that way beforehand too.

@Exempt-Medic Exempt-Medic added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. is: refactor/cleanup Improvements to code/output readability or organizization. labels Sep 23, 2024
qwint
qwint approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pure code review, looks great

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 23, 2024
@BadMagic100
Copy link
Collaborator Author

kind of weird to me that there's a try/except exclusively for PlandoCharmCosts

In theory other stuff could be added in the future, so I didn't bother to check what was excluded by this. It may be due some rework at an indeterminate point in the future but didn't concern me for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwint qwint qwint approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BadMagic100 @qwint @Exempt-Medic