The Messenger: remove 3.8 compatibility #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be able to update |
Exempt-Medic
approved these changes
Sep 24, 2024
Exempt-Medic
added
is: maintenance
Berserker66
approved these changes
Sep 27, 2024
Berserker66
merged commit 0adcf8e
into
ArchipelagoMW:core_min_py_3_10
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Updates typing to 3.10+ and replaces str.replace with str.remove_prefix where relevant for a minimal speed increase.
How was this tested?
A few gens and tests. Existing tests hit all of the code paths that were touched here
If this makes graphical changes, please attach screenshots.