Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PKMN RB] Adds slot data that tells the tracker V5 logic should be considered #3995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palex00
Copy link
Contributor

@palex00 palex00 commented Sep 24, 2024

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Adds a flag to slot data that is just dummy-true so the poptracker can test for whether the slot data exists to apply 0.5.1 or 0.5.0 logic for Pokémon RB.

How was this tested?

Generated a game successfully. Connected with a Debug Pack, verified slot data was present.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 24, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Sep 25, 2024
@Exempt-Medic
Copy link
Collaborator

@Alchav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants