Landstalker: remove global ref to multiworld #4175
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cached_spheres` holds a reference to the multiworld, which leaks the multiworld if multidata is skipped. Instead of making it a class variable, give a reference to each matching world.
github-actions
bot
added
the
waiting-on: peer-review
|
@Dinopony as world maintainer |
|
Looks good to me, is there anything I must do for it to be merged? |
Exempt-Medic
added
is: bug/fix
Exempt-Medic
removed
the
waiting-on: world-maintainer
Exempt-Medic
approved these changes
Nov 12, 2024
Exempt-Medic
added
waiting-on: core-review
@Dinopony Generally, you can just leave an approving review and say what you tested. Should be able to go to "Files changed" and then "Review Changes" |
Dinopony
approved these changes
Nov 12, 2024
|
Managed to test generating a few random seeds, it appears to be working. Thanks for making that change 👍 |
|
If it cleans up correctly now anyway, is the modify multidata actually still necessary? |
|
I don't know but I suppose so. |
NewSoupVi
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
LandstalkerWorld's
cached_spheresholds a reference to the multiworld, which leaks the multiworld if multidata is skipped. Instead of making it a class variable, give a reference to each matching world. These count as circular references, so the multiworld is correctly GC'ed even if multidata is skipped.How was this tested?
Run on console:
python Generate.py --seed=42 --skip_outputBefore:
After: (no error)