Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS3: List compatible static randomizer versions in slot data #4178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DS3: List compatible static randomizer versions in slot data #4178

wants to merge 1 commit into from
+10 −0

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Nov 11, 2024

What is this fixing or adding?

This will make it easier for players to understand when they have a
mismatch between their DS3 apworld and their local randomizer version,
mitigating a common source of confusion and support requests.

How was this tested?

N/A

@nex3
DS3: List compatible static randomizer versions in slot data
824bcfb 
This will make it easier for players to understand when they have a
mismatch between their DS3 apworld and their local randomizer version,
mitigating a common source of confusion and support requests.
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 11, 2024
Exempt-Medic
Exempt-Medic approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the comparison method works (so it accounts for text like "beta" through assumed consistent formatting) this LGTM.

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 12, 2024
nicholassaylor
nicholassaylor approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with same assuptions that Medic has

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 12, 2024
@nex3
Copy link
Contributor Author

nex3 commented Nov 12, 2024 •
edited
Loading

Yeah, the expectation is that these versions are parsed and compared according to the Semver standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nex3 @Exempt-Medic @nicholassaylor