-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter: add and use new afs_mode
mode method
#28132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
1ebd840
to
7b7b5f0
Compare
Advanced failsafe is not enabled by default, hence the 0 cost. For CubeOrange this costs 72 bytes. |
I can't say that I'm a huge fan of AFS spreading out into the mode library like this. Sorry, I've never liked how it's (not) integrated with our other failsafes so I prefer it be kept separate where possible. |
Yeah, its not great. But to enable custom modes we have to remove all switches using mode numbers. Doing it this way means that custom modes will inherit the behavior from guided mode. |
Another extract from #28110. This removes as mode number switch and replaces with a mode method that returns the advanced failsafe mode category.