Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: ardupilotwaf: esp32 does not have hardware double #28883

Merged

Conversation

srmainwaring
Copy link
Contributor

There is no hardware double on esp32.

@tpwrules
Copy link
Contributor

tpwrules commented Dec 16, 2024

I would prefer to see this in AP_HAL/boards/esp32.h like Linux and QURT.

But you are correct, but also I don't think it had any meaningful effect.

Copy link
Collaborator

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logincally correct, but its also ok to do it in AP_HAL/boards/esp32.h, i dont mind which, do we just merge this PR and move on .?

srmainwaring and others added 2 commits December 26, 2024 11:17
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@tpwrules tpwrules force-pushed the prs/pr-esp32-no-hardware-double branch from 4394c0e to dfc1375 Compare December 26, 2024 17:22
@tpwrules tpwrules merged commit 75da826 into ArduPilot:master Dec 27, 2024
99 checks passed
@srmainwaring srmainwaring deleted the prs/pr-esp32-no-hardware-double branch December 27, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants