Move python packages to requirements.txt #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TunaLobster
force-pushed
the
pr/add-requirements-txt
branch
from
962b383 to
18834fd
Compare
|
@TunaLobster is this still something pending or should we close? |
|
I think it's still relevant. |
|
@peterbarker Does this look good to you? |
TunaLobster
force-pushed
the
pr/add-requirements-txt
branch
2 times, most recently
from
da76ea5 to
abd97d9
Compare
TunaLobster
force-pushed
the
pr/add-requirements-txt
branch
from
abd97d9 to
7939daf
Compare
|
Rebased and moved the python version checks in the bash script to the requiremts.txt file so those now also work on Windows. Checked that it worked on my Ubuntu 24.04 system. I don't have a Windows machine to test this with. |
|
Rebased and moved the python version checks in the bash script to the requiremts.txt file so those now also work on Windows. Checked that it worked on my Ubuntu 24.04 system. I don't have a Windows machine to test this with. CI likes it though! |
peterbarker
approved these changes
Sep 29, 2024
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELAY MERGE. There are dependencies that need to be merged before this can go in. See ArduPilot/sphinxcontrib-youtube#4.
This is a change for easier maintenance between the install scripts. Also works as an added bonus to check that the build dependencies are working on the packages ArduPilot maintains.
CI will fail on this PR. I ran this change using my sphinxcontrib-youtube repo and you can see the passing CI change over here.
https://github.com/TunaLobster/ardupilot_wiki/actions/runs/3106686180
https://github.com/TunaLobster/ardupilot_wiki/actions/runs/3106686182