-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use direct call to sphinx build for faster build #5518
Conversation
abc3370
to
77d1eb1
Compare
need newer sphinx version to work and updated youtube plugin |
hum ... look like the current CI is just failing silently :
Will have to find a solution for this to pass CI |
removing ?t=103 should do the trick |
8c9d5d7
to
86628e8
Compare
@Ryanf55 thx for the review, I didn't do py3 codestyle update as last time it was a blocker for Peter. I will do in a following PR |
7bc7e9a
to
258dcda
Compare
258dcda
to
e73b6ba
Compare
e73b6ba
to
6cd7cbf
Compare
6cd7cbf
to
fcbea20
Compare
fcbea20
to
0a753ac
Compare
@peterbarker that show some small diff on the doctrees for the nav bar, but that seems unrelated. An example I saw is terrain navigation for copter. It is linked in two place : First time setup / configuration / failsafes mechnism and Mission Planning / terrain following. With the build I did with this PR, it was hold by Mission Planning This is just the navigation tree that change. @Ryanf55 on copter wiki, I gain about 30-40s per build using this, mostly per the multi cpu use for the parsing. Notice that using the sphinx-build is what make is using. If you open the makefile it calls sphinx-build. So we were creating a new process to call make to call sphinx-build. This PR save some ressources on this. I can still remove the part that use multiple cpu and stick with 1 per default as before, I just tried to max out the cpu usage with some ruling that are what they are ! It could be interesting to test on the build server if it is faster to do build sequencially with full cpu usage or continue to try parallele build with lower cpu count. |
Well, I'm OK with this - Henry? |
Thanks for the info, great to see! |
remove subprocess call for building (make things a bit faster)
use 2 cpu for inventory parsing and building. We could probably raise this more build it will collide with the parallel build.
On rover wiki building it save 30s.