You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found an issue where if the c parser gets a message that does not pass the checksum check, and the second checksum byte is MAVLINK_STX the parser will get out of sync and won't be able to parse the next message, possibly more than that depending on their content.
The issue is with the mavlink_parse_char function in mavlink_helpers.h. The code there checks if the second checksum byte is MAVLINK_STX and if it is then it counts it as the start of the next message. I stumbled this issue when testing out the PingRx ADS-B with ArduCopter, which for some reason sends messages not defined in the uAvionix xml. This caused the parser to fail parsing them due to the crc_extra being wrong, which in turn sometimes leads to 20 seconds without successfully parsed messages. Obviously adding the missing messages to the xml could solve it in this case but I don't see the reason behind this check:
I found an issue where if the c parser gets a message that does not pass the checksum check, and the second checksum byte is MAVLINK_STX the parser will get out of sync and won't be able to parse the next message, possibly more than that depending on their content.
The issue is with the
mavlink_parse_char
function inmavlink_helpers.h
. The code there checks if the second checksum byte is MAVLINK_STX and if it is then it counts it as the start of the next message. I stumbled this issue when testing out the PingRx ADS-B with ArduCopter, which for some reason sends messages not defined in the uAvionix xml. This caused the parser to fail parsing them due to the crc_extra being wrong, which in turn sometimes leads to 20 seconds without successfully parsed messages. Obviously adding the missing messages to the xml could solve it in this case but I don't see the reason behind this check:The text was updated successfully, but these errors were encountered: