Mavutil: fix wrong sysid_state update from sysid mismatch #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a link with multiple mavlink device, we store the state of all device into the sysid holding the port which is tottally wrong.
The easiest way to see this bug in action is to run two SITL instance connect via mavlink. Then on either mavproxy instance, use "alllinks mode guided" the SITL instance directly connect to mavproxy will update its mode fine, the other will change to another mode
GDB screen from mavproxy on the call of mavutil post_message() function
After fix :
