Fix prompt clone error handling

Arize-ai · Jan 11, 2025 · 09011f3 · 09011f3
1 parent fa35ccf
commit 09011f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/phoenix/server/api/mutations/prompt_mutations.py b/src/phoenix/server/api/mutations/prompt_mutations.py
@@ -247,11 +247,9 @@ async def clone_prompt(self, info: Info[Context, None], input: ClonePromptInput)
             new_prompt.prompt_versions = new_versions
 
             session.add(new_prompt)
-            await session.flush()
 
             try:
                 await session.commit()
             except (PostgreSQLIntegrityError, SQLiteIntegrityError):
                 raise Conflict(f"A prompt named '{input.name}' already exists")
-
         return to_gql_prompt_from_orm(new_prompt)
diff --git a/tests/unit/server/api/mutations/test_prompt_mutations.py b/tests/unit/server/api/mutations/test_prompt_mutations.py
@@ -976,5 +976,8 @@ async def test_clone_prompt_fails_with_duplicate_name(
         # clone prompt
         result = await gql_client.execute(self.CLONE_PROMPT_MUTATION, variables)
         assert len(result.errors) == 1
-        assert "UNIQUE constraint failed: prompts.name" in result.errors[0].message
+        assert (
+            f"A prompt named '{variables['input']['name']}' already exists"
+            in result.errors[0].message
+        )
         assert result.data is None