Properly display error messages for prompt save and clone mutations

Arize-ai · Jan 11, 2025 · 26858a7 · 26858a7
1 parent 0812a9e
commit 26858a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/app/src/pages/playground/UpsertPromptFromTemplateDialog.tsx b/app/src/pages/playground/UpsertPromptFromTemplateDialog.tsx
@@ -14,6 +14,7 @@ import {
   SavePromptForm,
   SavePromptSubmitHandler,
 } from "@phoenix/pages/playground/SavePromptForm";
+import { getErrorMessagesFromRelayMutationError } from "@phoenix/utils/errorUtils";
 
 type UpsertPromptFromTemplateProps = {
   instanceId: number;
@@ -109,10 +110,10 @@ export const UpsertPromptFromTemplateDialog = ({
           setDialog(null);
         },
         onError: (error) => {
-          // eslint-disable-next-line no-console
-          console.error(error);
+          const message = getErrorMessagesFromRelayMutationError(error);
           notifyError({
             title: "Error creating prompt",
+            message: message?.[0],
           });
           setDialog(null);
         },
@@ -161,10 +162,10 @@ export const UpsertPromptFromTemplateDialog = ({
           setDialog(null);
         },
         onError: (error) => {
-          // eslint-disable-next-line no-console
-          console.error(error);
+          const message = getErrorMessagesFromRelayMutationError(error);
           notifyError({
             title: "Error updating prompt",
+            message: message?.[0],
           });
           setDialog(null);
         },

diff --git a/app/src/pages/prompt/ClonePromptDialog.tsx b/app/src/pages/prompt/ClonePromptDialog.tsx
@@ -18,6 +18,7 @@ import {
 } from "@phoenix/components";
 import { useNotifySuccess } from "@phoenix/contexts/NotificationContext";
 import { ClonePromptDialogMutation } from "@phoenix/pages/prompt/__generated__/ClonePromptDialogMutation.graphql";
+import { getErrorMessagesFromRelayMutationError } from "@phoenix/utils/errorUtils";
 
 export const ClonePromptDialog = ({
   promptId,
@@ -78,8 +79,9 @@ export const ClonePromptDialog = ({
         });
       },
       onError: (error) => {
+        const message = getErrorMessagesFromRelayMutationError(error);
         setError("root", {
-          message: error.message,
+          message: message?.[0] ?? "An error occurred",
         });
       },
     });