-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sessions): separate migration script for populating the project sessions table #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Dec 4, 2024
RogerHYang
changed the title
fix: separate migration script for populating the project sessions table
fix(sessions): separate migration script for populating the project sessions table
Dec 4, 2024
mikeldking
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @RogerHYang ! maybe we put this in the MIGRATION.md so we can always link to it
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
mikeldking
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Usage
Set environment variable
export PHOENIX_SQL_DATABASE_URL=sqlite:////phoenix.db
Run
alembic
cd src/phoenix/db/ alembic upgrade head
Run script