feat: Spike out dummy PromptVersion connection #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
dosubot
bot
added
size:L
RogerHYang
approved these changes
Dec 17, 2024
Comment on lines
12
to
14
| class PromptTemplateType(str, Enum): | ||
| TEXT = "text" | ||
| JSON = "json" |
There was a problem hiding this comment.
is this supposed to match what's in the DB?
sa.Column(
"template_type",
sa.String,
sa.CheckConstraint(
"template_type IN ('chat', 'str')",
name="template_type",
),
nullable=False,
),
Comment on lines
18
to
23
| class PromptTemplateFormat(str, Enum): | ||
| MUSTACHE = "mustache" | ||
| FSTRING = "fstring" | ||
|
|
mikeldking
reviewed
Dec 17, 2024
mikeldking
reviewed
Dec 17, 2024
| description: String! | ||
| templateType: PromptTemplateType! | ||
| templateFormat: PromptTemplateFormat! | ||
| template: JSON! |
There was a problem hiding this comment.
I think we can make this a union type and give it a bit more structure
mikeldking
reviewed
Dec 17, 2024
src/phoenix/server/api/queries.py
Outdated
| @@ -612,6 +617,85 @@ def prompts( | |||
| args=args, | |||
| ) | |||
|
|
|||
| @strawberry.field | |||
| async def prompt_versions( | |||
mikeldking
force-pushed
the
dustin/spike-out-prompthub-gql
branch
from
66d8379 to
45fb1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5754