Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): Render model invocation params in prompt details view #5780

Conversation

cephalization
Copy link
Contributor

prompt.invocation.params.mov

Resolves #5777

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 18, 2024
Comment on lines +89 to +90
width={PROMPT_VERSIONS_LIST_WIDTH}
minWidth={PROMPT_VERSIONS_LIST_WIDTH}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should likely be set to width=100% and have the parent constrain the width with a px value. That way we can render this list in both the prompt aside and the versions tab and let the parent decide how much space it takes up.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 18, 2024
@cephalization cephalization changed the title feat(prompts): Render model invocation params in propt details view feat(prompts): Render model invocation params in prompt details view Dec 19, 2024
@mikeldking mikeldking merged commit 55afe18 into prompts Dec 19, 2024
48 of 49 checks passed
@mikeldking mikeldking deleted the cephalization/prompts/5777-show-invocation-params-prompt-details branch December 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants