feat: Add Prompt to setPromptVersionTag mutation #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
dosubot
bot
added
size:S
mikeldking
reviewed
Jan 11, 2025
| @@ -31,6 +32,7 @@ class SetPromptVersionTagInput: | |||
| @strawberry.type | |||
| class PromptVersionTagMutationPayload: | |||
| prompt_version_tag: Optional[PromptVersionTag] | |||
| prompt: Optional[Prompt] | |||
There was a problem hiding this comment.
Technically should always return this
There was a problem hiding this comment.
do you want the delete mutation to always return the prompt as well?
| @@ -101,4 +106,6 @@ async def set_prompt_version_tag( | |||
| raise Conflict("Failed to update PromptVersionTag.") | |||
|
|
|||
| version_tag = to_gql_prompt_version_tag(updated_tag) | |||
| return PromptVersionTagMutationPayload(prompt_version_tag=version_tag, query=Query()) | |||
| return PromptVersionTagMutationPayload( | |||
| prompt_version_tag=version_tag, prompt=prompt, query=Query() | |||
There was a problem hiding this comment.
I think you forgot to make it a gal type
dosubot
bot
added
size:M
mikeldking
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5957