feat: phoenix.otel infers GRPC port from env
#6017
Merged
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mikeldking
reviewed
Jan 13, 2025
| @@ -413,7 +412,7 @@ def _construct_http_endpoint(parsed_endpoint: ParseResult) -> ParseResult: | |||
|
|
|||
|
|
|||
| def _construct_grpc_endpoint(parsed_endpoint: ParseResult) -> ParseResult: | |||
| return parsed_endpoint._replace(netloc=f"{parsed_endpoint.hostname}:{_DEFAULT_GRPC_PORT}") | |||
| return parsed_endpoint._replace(netloc=f"{parsed_endpoint.hostname}:{get_env_grpc_port()}") | |||
There was a problem hiding this comment.
I think in general this is good - though agree an explicit way is necessary
mikeldking
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
PHOENIX_GRPC_PORTis typically a server-side variable, this provides an intuitive mechanism to improve the port-inference logic used inphoenix-otel.We should consider also adding an explicit override that will force using either gRPC or HTTP regardless of endpoint (which would be easier than our original proposed solution of explicitly setting the exporter).