Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedmen's optimization suggestions #425

Open
Tracked by #426
Kexanone opened this issue Dec 14, 2018 · 0 comments
Open
Tracked by #426

Dedmen's optimization suggestions #425

Kexanone opened this issue Dec 14, 2018 · 0 comments
Labels
change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Milestone

Comments

@Kexanone
Copy link
Member

Kexanone commented Dec 14, 2018

private _JIP_id = [_params, compile _pastedText, 0, _dummyObject] call Achilles_fnc_spawn;
compiling code is a waste. The game will turn it back to string. Then send the string over, and compile it on the target to execute it there. You're better off just sending a string and compiling once.

https://github.com/ArmaAchilles/Achilles/blob/0e1d0bd1a66911e517cd1c505a3d268412a017d8/%40AresModAchillesExpansion/addons/functions_f_ares/common/fn_GetFarthest.sqf

params [ ["_pointOfReference", [0,0,0], [[]]], ["_candidateObjects", [], [[]]] ];
private _distObjects = _candidateObjects apply {[_pointOfReference distance _x, _x]};
_distObjects sort false;
(_distObjects select 0) param [1, objNull];

https://github.com/ArmaAchilles/Achilles/blob/0e1d0bd1a66911e517cd1c505a3d268412a017d8/%40AresModAchillesExpansion/addons/functions_f_ares/common/fn_GetNearest.sqf
same code. Just sort true

@Kexanone Kexanone added change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Dec 14, 2018
@Kexanone Kexanone added this to the Backlog milestone Dec 14, 2018
@Kexanone Kexanone added sticky Issue that is of very high importance or as a part reminder. and removed sticky Issue that is of very high importance or as a part reminder. labels Dec 14, 2018
@Kexanone Kexanone mentioned this issue Dec 14, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Development

No branches or pull requests

1 participant