Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify permissions structure #268

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Simplify permissions structure #268

merged 1 commit into from
Aug 14, 2023

Conversation

jskowronski39
Copy link
Collaborator

This will:

  • simplify permissions model by removing nested objects and making this structure more "flat"

@jskowronski39 jskowronski39 requested a review from a team as a code owner August 14, 2023 13:59
@jskowronski39 jskowronski39 requested review from veteran29 and removed request for a team August 14, 2023 13:59
@jskowronski39 jskowronski39 mentioned this pull request Aug 14, 2023
Merged
@veteran29 veteran29 added the enhancement Fixes and improvements for existing feature label Aug 14, 2023
@veteran29 veteran29 merged commit 92ef575 into dev Aug 14, 2023
5 checks passed
@veteran29 veteran29 deleted the feature/simplify_permissions_structure branch August 14, 2023 19:01
jskowronski39 added a commit that referenced this pull request Aug 14, 2023
@jskowronski39
Entities refactor (#269)
fc2bf8a 
This will:
- Remove interfaces for entities
- Remove setters; add behaviors to entities
- Remove "type" property from AbstractMod and move it to
SteamWorkshopMod
- add few improvements in templates

This requires #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
enhancement Fixes and improvements for existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskowronski39 @veteran29