Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change access modifiers to private #323

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Change access modifiers to private #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Api/Input/Attendance/AttendanceInput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ class AttendanceInput
{
#[Assert\NotBlank]
#[Assert\Length(max: 255)]
protected ?string $missionId = null;
private ?string $missionId = null;

#[Assert\NotBlank]
#[SteamProfileId]
protected ?int $playerId = null;
private ?int $playerId = null;

public function getMissionId(): ?string
{
Expand Down
8 changes: 4 additions & 4 deletions src/Api/Output/Attendance/AttendanceOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

class AttendanceOutput
{
protected ?string $id = null;
protected ?\DateTimeInterface $createdAt = null;
protected ?string $missionId = null;
protected ?int $playerId = null;
private ?string $id = null;
private ?\DateTimeInterface $createdAt = null;
private ?string $missionId = null;
private ?int $playerId = null;

public function getId(): ?string
{
Expand Down
12 changes: 6 additions & 6 deletions src/Api/Output/Dlc/DlcOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

class DlcOutput
{
protected ?string $id = null;
protected ?string $name = null;
protected ?\DateTimeInterface $createdAt = null;
protected ?\DateTimeInterface $lastUpdatedAt = null;
protected ?int $appId = null;
protected ?string $directory = null;
private ?string $id = null;
private ?string $name = null;
private ?\DateTimeInterface $createdAt = null;
private ?\DateTimeInterface $lastUpdatedAt = null;
private ?int $appId = null;
private ?string $directory = null;

public function getId(): ?string
{
Expand Down
18 changes: 9 additions & 9 deletions src/Api/Output/Mod/ModOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@

class ModOutput
{
protected ?string $id = null;
protected ?string $name = null;
protected ?\DateTimeInterface $createdAt = null;
protected ?\DateTimeInterface $lastUpdatedAt = null;
protected ?string $source = null;
protected ?string $status = null;
protected ?string $type = null;
protected ?int $itemId = null;
protected ?string $directory = null;
private ?string $id = null;
private ?string $name = null;
private ?\DateTimeInterface $createdAt = null;
private ?\DateTimeInterface $lastUpdatedAt = null;
private ?string $source = null;
private ?string $status = null;
private ?string $type = null;
private ?int $itemId = null;
private ?string $directory = null;

public function getId(): ?string
{
Expand Down
4 changes: 2 additions & 2 deletions src/Api/Output/ModList/ModListDetailsOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

class ModListDetailsOutput extends ModListOutput
{
protected array $mods = [];
protected array $dlcs = [];
private array $mods = [];
private array $dlcs = [];

/**
* @return ModOutput[]
Expand Down
12 changes: 6 additions & 6 deletions src/Api/Output/ModList/ModListOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

class ModListOutput
{
protected ?string $id = null;
protected ?string $name = null;
protected bool $active;
protected bool $approved;
protected ?\DateTimeInterface $createdAt = null;
protected ?\DateTimeInterface $lastUpdatedAt = null;
private ?string $id = null;
private ?string $name = null;
private bool $active;
private bool $approved;
private ?\DateTimeInterface $createdAt = null;
private ?\DateTimeInterface $lastUpdatedAt = null;

public function getId(): ?string
{
Expand Down
2 changes: 1 addition & 1 deletion src/Entity/UserGroup/UserGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class UserGroup extends AbstractBlamableEntity
{
protected Collection $users;
private Collection $users;
private string $name;
private ?string $description;
private UserGroupPermissions $permissions;
Expand Down
2 changes: 1 addition & 1 deletion src/Repository/Mod/ModRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public function findIncludedRequiredSteamWorkshopMods(ModList $modList): array
return $qb->getQuery()->getResult();
}

protected function applyIncludedModsFilter(QueryBuilder $queryBuilder, ModList $modList): void
private function applyIncludedModsFilter(QueryBuilder $queryBuilder, ModList $modList): void
{
$expr = $queryBuilder->expr();

Expand Down
10 changes: 5 additions & 5 deletions src/Security/Authenticator/DiscordAuthenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@
*/
class DiscordAuthenticator extends OAuth2Authenticator implements AuthenticationEntryPointInterface
{
protected const DISCORD_CLIENT_NAME = 'discord_main';
private const DISCORD_CLIENT_NAME = 'discord_main';

protected const HOME_INDEX_PAGE_ROUTE_NAME = 'app_home_index';
protected const HOME_JOIN_US_PAGE_ROUTE_NAME = 'app_home_join_us';
protected const LOGIN_PAGE_ROUTE_NAME = 'app_security_connect_discord';
protected const SUPPORTED_ROUTE_NAME = 'app_security_connect_discord_check';
private const HOME_INDEX_PAGE_ROUTE_NAME = 'app_home_index';
private const HOME_JOIN_US_PAGE_ROUTE_NAME = 'app_home_join_us';
private const LOGIN_PAGE_ROUTE_NAME = 'app_security_connect_discord';
private const SUPPORTED_ROUTE_NAME = 'app_security_connect_discord_check';

public function __construct(
private ClientRegistry $clientRegistry,
Expand Down
2 changes: 1 addition & 1 deletion src/Twig/CalendarExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function createMissionIcalLink(MissionDto $mission): string
return $this->createMissionEventLink($mission)->ics();
}

protected function createMissionEventLink(MissionDto $mission): Link
private function createMissionEventLink(MissionDto $mission): Link
{
$fromDate = \DateTime::createFromImmutable($mission->getDate())->sub(new \DateInterval('PT30M'));
$toDate = \DateTime::createFromImmutable($mission->getDate())->add(new \DateInterval('PT2H'));
Expand Down
2 changes: 1 addition & 1 deletion src/Twig/ImgproxyExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function getProxyImageUrl(string $url, int $width = 0, int $height = 250,
/**
* https://github.com/imgproxy/imgproxy/blob/master/examples/signature.php.
*/
protected function getSignature(string $path): string
private function getSignature(string $path): string
{
$binaryKey = pack('H*', $this->proxyKey);
if (empty($binaryKey)) {
Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Dlc/SteamStoreArma3DlcUrlValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

class SteamStoreArma3DlcUrlValidator extends AbstractValidator
{
protected const ARMA_3_GAME_ID = 107410;
private const ARMA_3_GAME_ID = 107410;

public function __construct(
EntityManagerInterface $entityManager,
Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Mod/SteamWorkshopArma3ModUrlValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

class SteamWorkshopArma3ModUrlValidator extends AbstractValidator
{
protected const ARMA_3_GAME_ID = 107410;
private const ARMA_3_GAME_ID = 107410;

public function __construct(
EntityManagerInterface $entityManager,
Expand Down
Loading