New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store question service #50

Merged

AbelMH1 merged 38 commits into develop from storeQuestionService

Mar 13, 2024

marco-qg commented Mar 12, 2024

Mock is commented so no questions are being shown. We might need to uncomment it in a future if we store no questions.

MarcosBarrilVillaverde and others added 15 commits

February 24, 2024 20:45


          first version of the backend for the question stororage microservice

0e5b801


          Minor fix dokerfile

a0ad56c


          Added timestampt to stored questions model

b8eb199


          Inicio del prototipo del almacen de preguntas

b2941cf


          Merge remote-tracking branch 'origin/develop' into storeQuestionService

bb0e886


          Fixes on structured of the data stored

fc4b0d9


          Avance conexión

e8417a7


          Unfortunately, light mode

e71ea92


          added commented data for testing purpose

e8e7da7


          Minor fixes

3534e7d


          Merge branch 'storeQuestionService' of https://github.com/Arquisoft/w…

955981c

…iq_es6c into storeQuestionService


          Minor fix

d3104ab


          connection fixed, pending style improvement

0f1f85a


          commented code for testing purposes

7fde766


          Style done

2ccfc61

marco-qg requested a review from AbelMH1

March 12, 2024 15:50

marco-qg assigned marco-qg and MarcosBarrilVillaverde

marco-qg added the development label

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-model.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

gatewayservice/gateway-service.js Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

AbelMH1 left a comment

Quedó la revisión a medias, continuo después

AbelMH1 reviewed

View reviewed changes

storeQuestionService/package.json Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

gatewayservice/gateway-service.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved

MarcosBarrilVillaverde and others added 5 commits

March 13, 2024 13:50


          Update gatewayservice/gateway-service.js fixed new route in questions

eef9653

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js Added new route in tests

a015019

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js

e352872

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js

de2e940

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js

5d22841

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>

AbelMH1 requested changes

View reviewed changes

AbelMH1 left a comment

Falta eliminar el main y corregir pequeños errores que quedaron sin resolver

MarcosBarrilVillaverde and others added 5 commits

March 13, 2024 13:52


          Update storeQuestionService/store-q.test.js Added new route in tests

bab0682

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js Added new route in tests

fe390af

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update storeQuestionService/store-q.test.js Added new route in tests

933ce9e

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update gatewayservice/gateway-service.js Added new route in tests

9536c6b

Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>


          Update store-q.test.js fixed questions format

40f0795

AbelMH1 reviewed

View reviewed changes

storeQuestionService/store-q.test.js Outdated Show resolved Hide resolved


          Deleted useless file

5d91629

Author

marco-qg commented Mar 13, 2024

Tras los cambios realizados:

:(

Author

marco-qg commented Mar 13, 2024 •

edited

Loading

Tras los cambios realizados: :(

Fixed(pending push)

marco-qg and others added 3 commits

March 13, 2024 16:49


          Fixed body-parser problem and commented mock question

3e40311


          added post history/question. It works, i ve tested it.

95b4d1b


          Update store-q.test.js fixed

1ae5550

sonarqubecloud bot commented Mar 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
38.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AbelMH1 approved these changes

View reviewed changes

AbelMH1 left a comment

Creo que el endpoint POST /history/question no es necesario dentro del fichero gateway-service.js puesto que desde la webapp solo se va a llamar al GET /history/questions. El resto parece estar ya todo perfecto.

AbelMH1 merged commit 998a6ee into develop

2 checks passed

AbelMH1 mentioned this pull request

Autoinforme Abel M.H. #68

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels