Webapp interface #89
Merged
Webapp interface #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the call is not working
…have to fix other problems)
marco-qg
reviewed
Apr 10, 2024
webapp/src/components/Menu.js
Outdated
| <Button text = "Historial" name="openHistory" onClick={() => openHistory()}/> | ||
| </div> | ||
|
|
||
| <h2>Esto irá en el nav(?)</h2> |
There was a problem hiding this comment.
Hay que decidir ya cómo poner esto, aunque probablemente me encargue yo mañana
webapp/src/components/game/Game3.js
Outdated
There was a problem hiding this comment.
Va a haber que sacar mucho código común con FirstGame para que no nos de problemas el sonar
|
AbelMH1
approved these changes
Apr 11, 2024
| console.log(`Game Service listening at http://localhost:${port}`); | ||
| }); | ||
|
|
||
| server.on('close', () => { |
There was a problem hiding this comment.
No tienes ni mongo en este servicio... Esto sobra
| // Route for getting questions | ||
| app.get('/gameUnlimitedQuestions', async (req, res) => { | ||
| try { | ||
| // TODO: Implement logic to fetch questions from MongoDB and send response |
| @@ -10,7 +10,8 @@ const authServiceUrl = process.env.AUTH_SERVICE_URL || 'http://localhost:8002'; | |||
| const userServiceUrl = process.env.USER_SERVICE_URL || 'http://localhost:8001'; | |||
| const userStatsServiceUrl = process.env.USER_STATS_SERVICE_URL || 'http://localhost:8003'; | |||
| const storeQuestionsServiceUrl = process.env.STORE_QUESTION_SERVICE_URL || 'http://localhost:8004' | |||
| const questionsGeneratorServiceUrl = process.env.QUESTIONS_GENERATOR_SERVICE_URL || 'http://localhost:8007' | |||
| // const questionsGeneratorServiceUrl = process.env.QUESTIONS_GENERATOR_SERVICE_URL || 'http://localhost:8007' | |||
There was a problem hiding this comment.
Sobra
Suggested change
| // const questionsGeneratorServiceUrl = process.env.QUESTIONS_GENERATOR_SERVICE_URL || 'http://localhost:8007' |
| @@ -78,15 +79,74 @@ app.get('/history/questions', async (req, res) => { | |||
| } | |||
| }) | |||
|
|
|||
| app.get(`/questions`, async (req, res) => { | |||
| // app.get(`/questions`, async (req, res) => { | |||
| console.log(document.querySelector('h1')) | ||
|
|
||
| const gamesBT = document.getElementsByClassName('allAnswers'); | ||
| //expect(gamesBT).toHaveLength(4); |
There was a problem hiding this comment.
Buen test, se nota que se ha aplicado exitosamente el Ostrich algorithm
|
|
||
| var isApiCalledRef = false; | ||
| var gameId; | ||
| //var isApiCalledRef = false;//ASK - is this necessary? |
| // Recorrer el array desde el último elemento hasta el primero | ||
| for (let i = shuffledArray.length - 1; i > 0; i--) { | ||
| // Genera un índice aleatorio entre 0 y el índice actual | ||
| //const randomIndex = Math.floor(Math.random() * (i + 1)); |
There was a problem hiding this comment.
sobra
Suggested change
| //const randomIndex = Math.floor(Math.random() * (i + 1)); | |
There was a problem hiding this comment.
Buen fichero, me cuesta un poco comprender la lógica detrás de tan diversas operaciones pero parece estar correcto, no debería dar fallos.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.