Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes marco #90

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Bug fixes marco #90

merged 5 commits into from
Apr 5, 2024

Conversation

marco-qg
Copy link

@marco-qg marco-qg commented Apr 4, 2024

No description provided.

@marco-qg marco-qg marked this pull request as ready for review April 4, 2024 20:24
marco-qg
marco-qg commented Apr 4, 2024
View reviewed changes
webapp/public/index.html Outdated Show resolved Hide resolved
This was linked to issues Apr 4, 2024
Arreglar bug inicio sesión #85
Closed
Arreglar issue de SonarCloud #88
Closed
@marco-qg marco-qg self-assigned this Apr 4, 2024
@marco-qg marco-qg added the bug Something isn't working label Apr 4, 2024
@marco-qg marco-qg linked an issue Apr 4, 2024 that may be closed by this pull request
Eliminar monolito distribuido. #91
Closed
AbelMH1
AbelMH1 requested changes Apr 5, 2024
View reviewed changes
Copy link

@AbelMH1 AbelMH1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detalle

gatewayservice/gateway-service.js Outdated Show resolved Hide resolved
@marco-qg @AbelMH1
minor fix
80779b7 
Co-authored-by: Abel <114153419+AbelMH1@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

AbelMH1
AbelMH1 approved these changes Apr 5, 2024
View reviewed changes
Copy link

@AbelMH1 AbelMH1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo parece corregido correctamente

@AbelMH1 AbelMH1 merged commit 944a8ea into develop Apr 5, 2024
1 of 2 checks passed
@marco-qg marco-qg mentioned this pull request Apr 11, 2024
Closed
@AbelMH1 AbelMH1 mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelMH1 AbelMH1 AbelMH1 approved these changes

Assignees

@marco-qg marco-qg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminar monolito distribuido. Arreglar issue de SonarCloud Arreglar bug inicio sesión
2 participants
@marco-qg @AbelMH1