Fixed firestore _utils.py #21
Conversation
Fix for situations when numeric value equals to zero. If will not match in this cases and comparsion to None is needed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you @folkien , for contributing to this project, your support is much appreciated. A project committer will shortly review your contribution.
| @@ -76,13 +76,13 @@ def _decode_datastore(value): | |||
| elif value.get('booleanValue') is not None: | |||
| return bool(value['booleanValue']) | |||
|
|
|||
| elif value.get('bytesValue'): | |||
| elif value.get('bytesValue') is not None: | |||
There was a problem hiding this comment.
Could you please provide me an example, where this fails if is not None is note used here?
There was a problem hiding this comment.
Simple.
If value.get() returns integer 0 or float 0.0 then you will miss casting to int or float and returning proper value. Unfortunately values equal to zero are treated equal to False. But in this case this is a problem because we can store zero value inside Firestore and zero is also valid integer number. So it's better to check always with None and treat every not None value as valid.
There was a problem hiding this comment.
I believe you didn't understand my question. For integer and double, your logic is correct. But does the same apply for bytes? My question was specific to bytes, thus that's the line where I commented.
There was a problem hiding this comment.
Ok, thanks!
True, probably for bytes it's not needed.
|
Will you merge it? |
Fix for situations when numeric value equals to zero. If will not match in this cases and comparsion to None is needed.