Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected WebSocket closure should be handled #6

Open
tomcur opened this issue Feb 12, 2020 · 0 comments
Open

Unexpected WebSocket closure should be handled #6

tomcur opened this issue Feb 12, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tomcur
Copy link
Member

tomcur commented Feb 12, 2020 •
edited
Loading

WebSockets that close unexpectedly are currently an unhandled exception, breaking the page. The exceptions should be handled, for example by attempting to establish a new WebSocket connection and resubscribing lost subscriptions.

See: https://github.com/AstroPlant/astroplant-frontend-web/blob/8ea7ba008b638f111b95d44976e826fbb708f55f/src/modules/websocket/epic.ts
@tomcur tomcur added bug Something isn't working good first issue Good for newcomers labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomcur