Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ScrollToTop button #262

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Added ScrollToTop button #262

merged 4 commits into from
Jul 28, 2023

Conversation

saikiranreddy201
Copy link
Contributor

Related Issue

Closes: #132

Description of Changes

  • I have added the respective component and its functionality in the codebase
  • It matches the UI and I have tested it.

Checklist:

  • My code adheres to the established style guidelines of this project.
  • I have conducted a self-review of my code.
  • I have included comments in areas that may be difficult to understand.
  • I have made corresponding updates to the project documentation.
  • My changes have not introduced any new warnings.

Screenshots

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey👋🏼, @saikiranreddy201, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Anand on Twitter.


Give us a ⭐ to show some support
Keep Contributing 🚀

@Alkaison
Copy link
Collaborator

Revert the changes in pnpm.yaml as it was not suppose to make any changes into it.

@saikiranreddy201
Copy link
Contributor Author

Should I delete it and push it? @Alkaison

@Alkaison
Copy link
Collaborator

copy the current content from the repo for pnpm.yaml and paste it into the file and push.

Copy from here: https://github.com/ZeroOctave/resource-gallery/blob/main/pnpm-lock.yaml
Paste the whole content as it is.

@saikiranreddy201
Copy link
Contributor Author

saikiranreddy201 commented Jul 25, 2023

Hey @Alkaison, have a look at it now.
Let me know if I have to do anything more!

Copy link
Collaborator

@Alkaison Alkaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 👍

@Alkaison
Copy link
Collaborator

Can you share a video of the working of it?

@Alkaison Alkaison added review-done ready for merge PR has been reviewed and its ready to be merged. and removed waiting for review review-ongoing labels Jul 26, 2023
@saikiranreddy201
Copy link
Contributor Author

Here is the working video

Resource.Gallery.-.Resources.you.need.to.start.in.tech.-.Google.Chrome.2023-07-27.16-38-35.mp4

@Astrodevil Astrodevil merged commit 36ff0d4 into Astrodevil:main Jul 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc23 level1 ready for merge PR has been reviewed and its ready to be merged. review-done waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Need for back to top button which matches the UI
3 participants