fix: fix issue with widget not selecting place #196
Conversation
adriansberg
requested review from
jonasbrunvoll,
mikaelbr,
mortennordseth and
toretefre
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriansberg
force-pushed
the
adriansberg/fix-widget-not-selecting
branch
from
60cea0e
to
c19e940
Compare
|
From what I can see, this changes the current version of the widget (v2.6.0), but should probably be a new version? 🤔 |
|
Yeah, maybe it should? Thought that since it was a fix and not any breaking changes that it could be the same version so that it is updated, but I might've misunderstood how we treat the widget version. |
|
I can update to 2.6.1 |
It should be v2.8.0 I think, because this would be released with that version.
|
|
Ah, mega confused. What decides that the next release is 2.8.0 and not 2.7.1? I'd guess the trip in map changes. So. If I change the version in package.json to 2.8.0, run the script again then make a draft release that matches the version in package.json? |
|
Yes, since we are releasing with a new feature (add functionality) it will be 2.8.0 That sounds correct to me 👍 And unstage the v2.6.0 changes |
|
As long as we know that we'll release added changes and not a bug fix before the changes that is. |
|
Yep, that's something to consider. Maybe we shouldn't generate new widget versions for PRs like this and do it as a part of the release flow instead.
|
adriansberg
force-pushed
the
adriansberg/fix-widget-not-selecting
branch
from
c19e940
to
2c82167
Compare
The issue with the widget not selecting a place was due to the event listener on blur. The blur event was happening before the "combobox-commit" event which is the one that sets the place. A fix for this was to add event listener to the `mousedown` event instead of the `click` event in the combobox code. That was solved with a patch using `patch-package`. Also mentioned in this issue: github/combobox-nav#54 Also fixed an issue that showed "undefined" if selected place did not have a locality.
adriansberg
force-pushed
the
adriansberg/fix-widget-not-selecting
branch
from
2c82167
to
1c61f7e
Compare
The issue with the widget not selecting a place was due to the event listener on blur. The blur event was happening before the "combobox-commit" event which is the one that sets the place. A fix for this was to add event listener to the
mousedownevent instead of theclickevent in the combobox code. That was solved with a patch usingpatch-package. Also mentioned in this issue: github/combobox-nav#54Also fixed an issue that showed "undefined" if selected place did not have a locality.