Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with widget not selecting place #196

Merged
merged 1 commit into from
Jan 5, 2024

Commits on Jan 5, 2024

  1. fix: fix issue with widget not selecting place

    The issue with the widget not selecting a place was due to the event listener on blur. The blur event was happening before the "combobox-commit" event which is the one that sets the place. A fix for this was to add event listener to the `mousedown` event instead of the `click` event in the combobox code. That was solved with a patch using `patch-package`. Also mentioned in this issue: github/combobox-nav#54
    
    Also fixed an issue that showed "undefined" if selected place did not have a locality.
    adriansberg committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1c61f7e View commit details
    Browse the repository at this point in the history