fix: issue with caching when selecting transport filter #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriansberg
reviewed
Feb 14, 2024
|
Should the tests be working? |
|
Problem here is that FRAM tests runs on AtB tests so search results are differently sorted 😅 |
mikaelbr
force-pushed
the
mikael/e2e2
branch
from
b000843
to
bff55b2
Compare
mikaelbr
force-pushed
the
mikael/e2e2
branch
from
d292b91
to
4dc7d09
Compare
|
Is |
adriansberg
reviewed
Feb 16, 2024
|
It all depends on what tags we use (conventional commits allows for defining your own). But that said, this will be a fix as it now fixes cache issue which is a real bug 😄 Most cases adding tests is part of fix after either discovering a bug or when developing new things. |
adriansberg
reviewed
Feb 16, 2024
mikaelbr
force-pushed
the
mikael/e2e2
branch
from
4dc7d09
to
a05a693
Compare
adriansberg
approved these changes
Feb 16, 2024
mikaelbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache doesn't bust on transport mode, causing it not to work as expected. This adds a test case (e2e) to verify fix and fixes the issue.