-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update styling to make the linefilter and the search component appear more similar. #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent appear more similar.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikaelbr
reviewed
Feb 23, 2024
jonasbrunvoll
force-pushed
the
jonas/match_via_and_line_search_field
branch
from
February 23, 2024 14:29
4615089
to
ba26a69
Compare
Could this component be made more generic like it could be a basic input, and not necessarily connected to this line search in any way? |
mikaelbr
reviewed
Feb 27, 2024
…euable component.
mikaelbr
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AtB-AS/kundevendt/issues/16994
Background
Currently, the via search input field and the line search input field have different appearances. These fields should look the same.
Illustrations
Current solution / proposed solution
screenshots
Proposed solution
Use the same search component and styling to make sure that the input field for via search and the input field for line search appear similar.