feat: add functionality to specify whether a filter that should be initially checked. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UncheckedByDefault is initially checked.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriansberg
reviewed
Feb 26, 2024
| @@ -54,6 +59,13 @@ function AssistantLayout({ children, tripQuery }: AssistantLayoutProps) { | |||
| getTransportModeFilter, | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
| tripQuery.transportModeFilter = | |||
There was a problem hiding this comment.
Maybe setValuesWithLoading() should be used here as well? Like we looked at some time ago with some other changes. Or maybe not? I guess if the setValuesWithLoading is used we get an (possibly) unwanted route change.
And it's important to check whether transportModeFilter is set already, then the isUncheckedByDefault should not be taken into account and the filter should remain as is, since there's a chance the user has set the filters themselves. Haven't tested this code, but that might be how this works with the optional chaining and nullish coalescing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AtB-AS/kundevendt/issues/16683
Background
NFK have requested that flights are not part of the default transport methods in travel planner web. It should still be possible to enable for the users, but not selected as default.
This is default also in app and at Entur.
Proposed solution