feat: extend line filtering to support nfk

[jonasbrunvoll]

Closes https://github.com/AtB-AS/kundevendt/issues/17072

Background

Hanne found an issue with the line filter for NFK: https://github.com/AtB-AS/kundevendt/issues/17037#issuecomment-1963487733

The planner web filters lines by ID. For FRAM and AtB this works as line ID = line number (aka publicCode in Journey Planner API). Customers can therefore search by line number.

  {
    "id": "MOR:Line:100",
    "publicCode": "100"
  },
  {
    "id": "MOR:Line:101",
    "publicCode": "101"
  },

This is not the case for NFK. For example do line 1, 2 and 200 in Bodø have line ID 8001, 8002 and 8200. Also, some lines have the same line number, but different line IDs. For example:

 {
        "id": "NOR:Line:12_8371",
        "publicCode": "1"
  },
 {
        "id": "NOR:Line:12_8636",
        "publicCode": "1"
  },
 {
        "id": "NOR:Line:12_8001",
        "publicCode": "1"
  },

Illustrations

screenshots/video/figma

Proposed solution

In the proposed solution, all lines are fetched at the initial render of the line-filter component. Then, when a valid line number is written in the line filter component, any corresponding line id is included to the line whitelist of the trip search.

Acceptance Criteria

• Line filter works for all organizations (AtB, FRAM and NFK).
• Specified filters should not disappear when refreshing the page.
• Lines query should only be run initially and when refreshing the page. Otherwise, the lines should be fetched from cache.

Test input

Trip suggestions for testing.

• AtB: From Rønningsbakken, Trondheim, to Nidarosdomen, Trondheim.
• FRAM: From Molde, Molde, to Batnfjordsøra, Gjemnes.
• NFK: From Bodø sentrum, Bodø, to Universitetet, Bodø.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planner-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2024 0:23am

[adriansberg]

Let's have a huddle about this tomorrow, easier to point and explain various ideas instead of having several comments trying to convey the same information but resulting in potential misunderstandings.

I put together some of the thoughts in this commit, so we can have a look at that together: c24f555

[mikaelbr]

I think a very quick win would be to use https://www.downshift-js.com/use-multiple-selection here.

[jonasbrunvoll]

Expanding line filtering to use useMultipleSelection can perhaps be a separate task? This PR is getting pretty big already.

[adriansberg]

LGTM! Tested and works as expected, adding lines when they are entered and removing them when removed, after the debounce set to 750ms passes.

I reckon that this feature will be worked on to possibly implement the multiple selection that we talked about. Would be nice to have some tests for this then.