fix: set filter correctly when navigating back from details page

[jonasbrunvoll]

Closes https://github.com/AtB-AS/kundevendt/issues/17194

Background

When going into a details page and navigating back the filter for transport mode is not included in the query, causing the filter to be reset to default.

Illustrations

The recording displays how the same filters are active before and after navigating to the details page. This can be seen in both the filter buttons and URL parameters.

screenshots/video/figma

Skjermopptak.2024-03-14.kl.12.15.33.mov

Proposed solution

Including a string made up by the selected transport mode filters to generate the singleTripQueryString. Thus, the same string is available when the singleTripQueryString is decompressed, making it possible to set the parameters again when navigating back from details page.

Acceptance Criteria

• The set transport mode filter remains the same when going to details page and navigating back.
• Going to details page from copied url and navigating back keeps the transport mode filter.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planner-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:24pm

[mortennordseth]

Notater fra felles gjennomgang av PR:

• Legge til filter som query param i stedet for å utvide compressed query

[jonasbrunvoll]

I was unable to navigate to the details page when / was used as a delimiter. I therefore chose to use ___ instead.

[mortennordseth]

I was unable to navigate to the details page when / was used as a delimiter. I therefore chose to use ___ instead.

I think you should use query string instead (https://en.wikipedia.org/wiki/Query_string). For example ?filter=bus or ?filter=bus,rail. This is in line with what is done for the /assistant page as well

[mortennordseth]

You might disagree with me, but I don't think we should modify tripQueryStringToQueryParams without changing the decompressedQueryString. What about doing something like this?

  const tripSearchParams = router.query.id
    ? tripQueryStringToQueryParams(String(router.query.id))
    : undefined;

  if (tripSearchParams && router.query.filter) {
    tripSearchParams.append('filter', router.query.filter as string);
  }

This only requires us to add the filter as a query param to the href in /trip-pattern/index.tsx (already done) and to use it when redirecting back to the travel suggestions (the suggested code above)

[mortennordseth]

Nice