Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improves link information for departures with Open Graph (and minor SEO improvements) #287

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

mikaelbr
Copy link
Collaborator

@mikaelbr mikaelbr commented Apr 18, 2024

  • Sets proper title
  • Adds Open Graph metadata
  • Adds generated open graph image for departure stop place
  • Adds better meta description
  • Adds all departures to the sitemap to be able to crawl all pages by search engines.

This adds a large file checked into the repo, but I think as this is very static data that rarely changes it is better to have it checked in rather than generating it build time. We could move it outside as a separate package, but that feels excessive at this point. In any case... Lots of lines changed on this one.

Fixes https://github.com/AtB-AS/kundevendt/issues/17688

Example generated image for Open Graph / Social platforms:

image

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 10:45am

@mikaelbr mikaelbr force-pushed the mikael/better-seo-departures branch from ff88a06 to e198672 Compare April 18, 2024 19:10
@mikaelbr mikaelbr changed the title feat: improves SEO for departure pages feat: improves link information for departures with Open Graph (and minor SEO improvements) Apr 19, 2024
Copy link
Contributor

@mortennordseth mortennordseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 753,426 new lines LGTM :)

@mikaelbr mikaelbr merged commit 8a5b683 into main Apr 19, 2024
5 of 6 checks passed
@mikaelbr mikaelbr deleted the mikael/better-seo-departures branch April 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants