-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improves link information for departures with Open Graph (and minor SEO improvements) #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikaelbr
force-pushed
the
mikael/better-seo-departures
branch
from
April 18, 2024 19:10
ff88a06
to
e198672
Compare
mikaelbr
changed the title
feat: improves SEO for departure pages
feat: improves link information for departures with Open Graph (and minor SEO improvements)
Apr 19, 2024
mortennordseth
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 753,426 new lines LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a large file checked into the repo, but I think as this is very static data that rarely changes it is better to have it checked in rather than generating it build time. We could move it outside as a separate package, but that feels excessive at this point. In any case... Lots of lines changed on this one.
Fixes https://github.com/AtB-AS/kundevendt/issues/17688
Example generated image for Open Graph / Social platforms: