Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend travel mode filter selection to use selected_as_default property #293

Merged
merged 4 commits into from
May 14, 2024

Conversation

jonasbrunvoll
Copy link
Contributor

Closes https://github.com/AtB-AS/kundevendt/issues/17912

Background

FRAM and NFK have requested that some transport mode filters should be unchecked by default in both app and travel planner web. This request highlights a need that we need to address. As the number of organizations in the OMS grows, it becomes increasingly more difficult to find on singel transport mode configuration that will work well for all orgnaizations. Therefore, each organization should be able to configure their own desired default transportModes.

The requests from AtB, FRAM and NFK are as following:

  • AtB: All transport mode filters should be checked by default (7/7).
  • NFK: All transport mode filters except flight should be check by default (6/7).
  • FRAM: All transport mode filters except flight and train should be checked by default (5/7).
  • TROMS: All transport mode filters should be checked by default (7/7).
  • Innlandet: All transport mode filters except flight and train should be checked by default (5/7).

Illustrations

screenshots/video/figma

NFK
Skjermbilde 2024-05-07 kl  08 32 06

FRAM
Skjermbilde 2024-05-06 kl  15 07 18

AtB
Skjermbilde 2024-05-06 kl  15 30 19

Proposed solutionfinder

  • Add a function to determine whether the selectedAsDefault property is set for each filter.

Acceptence criteria

  • The correct transport mode filters are checked by default.
  • The user is still able to specify which transport mode filters to use during the search.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 9:57am

Copy link
Contributor

@mortennordseth mortennordseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@jonasbrunvoll jonasbrunvoll merged commit bc036ab into main May 14, 2024
5 of 6 checks passed
@jonasbrunvoll jonasbrunvoll deleted the jonas/update_selection_of_filter_config branch May 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants