feat: add note informing users about having to buy external ticket #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriansberg
reviewed
May 13, 2024
adriansberg
reviewed
May 13, 2024
adriansberg
reviewed
May 13, 2024
| @@ -35,6 +37,12 @@ export function AssistantDetails({ tripPattern }: AssistantDetailsProps) { | |||
| tripSearchParams.append('filter', router.query.filter as string); | |||
| } | |||
|
|
|||
| const requireTicketBooking = tripPattern.legs.some( | |||
There was a problem hiding this comment.
Is the same done in the app to know if booking is required?
There was a problem hiding this comment.
In the app, there is a function to check whether a leg in the trip requires a ticket that can not be must be bought through the app. https://github.com/AtB-AS/mittatb-app/blob/eb680679c754e8e56848ffe7983779c0794468ba/src/travel-details-screens/components/Trip.tsx#L106-L109.
The solution I used in this PR is pretty much the same approach to determine whether the BookingSection should appear.
planner-web/src/page-modules/assistant/details/trip-section/index.tsx
Lines 75 to 79 in a4453ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AtB-AS/kundevendt/issues/18065
Background
As mentioned in the conversation, the same note informing the users out the need to buy tickets from other sources than in the app, should also be shown in the planner web.
Originally posted by @mortennordseth in #17560
Illustrations
screenshots/video/figma
Proposed solution
Display the same message in planner web as already shown in the app.
Acceptance Criteria