refactor: map header icons and text #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelbr
reviewed
Oct 9, 2023
mikaelbr
reviewed
Oct 9, 2023
Co-authored-by: Mikael Brevik <mikaelbre@gmail.com>
mikaelbr
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the MapHeader icons from FeatureCategory to TransportMode to fit better with the StopPlace type. I also removed the street property from the MapHeader as this doesn't exist on the StopPlace object. I'll ask the designer what we should do about the subtitle in the header, but for now, I think it's better to remove it and don't use the question mark as a placeholder.
Closes https://github.com/AtB-AS/kundevendt/issues/11279
Screenshots