Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the appearance of the select component #414

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

jonasbrunvoll
Copy link
Contributor

Background

Currently, the Select and SearchableSelect components have different appearances. It is desirable that these components have the same appearance.

Illustrations

screenshots

Skjermbilde 2024-10-30 kl  13 03 19

Skjermbilde 2024-10-30 kl  13 03 29

Skjermbilde 2024-10-30 kl  13 03 39

Proposed solution

This PR includes the following:

  • The appearance of the Select component is updated to appear more similar to the SearchableSelect component.
  • The font-size of both Select and SearchableSelect is increased in mobile view.
  • Removes some unused css classes.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:10am

@jonasbrunvoll jonasbrunvoll changed the title feat: update the appearance of the select component fix: update the appearance of the select component Oct 31, 2024
@github-actions github-actions bot added the C-bug label Oct 31, 2024
@jonasbrunvoll jonasbrunvoll merged commit 03756f2 into main Oct 31, 2024
4 of 5 checks passed
@jonasbrunvoll jonasbrunvoll deleted the jonas/custome_select_component branch October 31, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants