Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update input label property type #422

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

jonasbrunvoll
Copy link
Contributor

@jonasbrunvoll jonasbrunvoll commented Nov 11, 2024

Update input label property type from TranslationString to string.

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:56am

Copy link
Contributor

@adriansberg adriansberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

@jonasbrunvoll
Copy link
Contributor Author

Is this change needed?

Not for anything other than trying to move as much logic as possible out of the input component. Makes no difference to the end user.

Copy link
Contributor

@mortennordseth mortennordseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change and more in line with the rest of the application.

@jonasbrunvoll jonasbrunvoll merged commit 5eef8b3 into main Nov 12, 2024
5 checks passed
@jonasbrunvoll jonasbrunvoll deleted the jonas/input_label branch November 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants