Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set the time of the incident manually #432

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

jonasbrunvoll
Copy link
Contributor

Closes https://github.com/AtB-AS/kundevendt/issues/19522

Background

Currently, the time is automatically set when reporting an incident. This results in several users sloppily specifying the correct time, which is again critical information.

Time of an incident should be mandatory to provided when needed. The user must specify the time himself.

Illustrations

screenshots Skjermbilde 2024-11-14 kl  12 13 10

Proposed solution

  • Add error message property to TimeSelector.
  • Set plannedDepartureTime to undefined in the state machines.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 11:27am

Comment on lines 156 to 157
state.context?.errorMessages['plannedDepartureTime']?.[0] ||
undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need || undefined here? 🤔

@jonasbrunvoll jonasbrunvoll merged commit 71ce965 into main Nov 14, 2024
4 of 5 checks passed
@jonasbrunvoll jonasbrunvoll deleted the jonas/time_mandatory branch November 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants