Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for corporation name and maintainers changes #10

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Fix for corporation name and maintainers changes #10

merged 7 commits into from
Oct 18, 2023

Conversation

WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Oct 16, 2023 •
edited
Loading

Description

  • Yahoo Japan Corporation => LY Corporation
  • update maintainers list

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

WindzCUHK and others added 7 commits October 16, 2023 15:47
@WindzCUHK
fix pipeline
684122b 
Signed-off-by: wfan <wfan@lycorp.co.jp>
@WindzCUHK
fix license
67be14c 
Signed-off-by: wfan <wfan@lycorp.co.jp>
@WindzCUHK
fix team
c4cf40b 
Signed-off-by: wfan <wfan@lycorp.co.jp>
@WindzCUHK
Update MAINTAINERS
5c9de2c 
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>
@WindzCUHK
fix PR template
62a212e 
Signed-off-by: wfan <wfan@lycorp.co.jp>
@WindzCUHK
fix markdown
cb02536 
Signed-off-by: wfan <wfan@lycorp.co.jp>
@WindzCUHK
fix test param
39593f9 
Signed-off-by: wfan <wfan@lycorp.co.jp>
mlajkim
mlajkim approved these changes Oct 18, 2023
View reviewed changes
Copy link

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mlajkim mlajkim merged commit 2c7a052 into master Oct 18, 2023
2 checks passed
@mlajkim mlajkim deleted the fix-corp-name branch October 18, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlajkim mlajkim mlajkim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WindzCUHK @mlajkim