Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression evaluator fails comparing two array with same content #243

Open
temi opened this issue Apr 16, 2024 · 0 comments
Open

expression evaluator fails comparing two array with same content #243

temi opened this issue Apr 16, 2024 · 0 comments
Milestone
6.3

Comments

@temi
Copy link
Contributor

temi commented Apr 16, 2024 •
edited
Loading

If two arrays have same content but different order, deepEqual returns false.

examples

ar1 = [1, 2, 3]
ar2 = [3,1,2]

actual

assert(deepEqual(ar1, ar2), false)

expected

true
temi added a commit that referenced this issue Apr 16, 2024
@temi
#243
a180af4 
- fixes unsorted array comparison
temi added a commit that referenced this issue Apr 18, 2024
@temi
#243
386e0f2 
- added config option to specify if sorting is required
- refactored code
chrisala added a commit that referenced this issue Apr 18, 2024
@chrisala
Merge pull request #244 from AtlasOfLivingAustralia/feature/issue243
8189cec 
#243
@chrisala chrisala added this to the 6.3 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
2 participants
@temi @chrisala