#800 replace imageId to fileName

AtlasOfLivingAustralia · Nov 13, 2023 · 114dee4 · 114dee4
1 parent a24aae9
commit 114dee4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/grails-app/controllers/au/org/ala/profile/api/ApiController.groovy b/grails-app/controllers/au/org/ala/profile/api/ApiController.groovy
@@ -549,10 +549,10 @@ class ApiController extends BaseController {
         }
     }
 
-    @Path("/api/opus/{opusId}/profile/{profileId}/image/{imageId}")
+    @Path("/api/opus/{opusId}/profile/{profileId}/image/{fileName}")
     @Operation(
             summary = "Get image associated with a profile",
-            operationId = "/api/opus/{opusId}/profile/{profileId}/image/{imageId}",
+            operationId = "/api/opus/{opusId}/profile/{profileId}/image/{fileName}",
             method = "GET",
             responses = [
                     @ApiResponse(
@@ -587,10 +587,10 @@ class ApiController extends BaseController {
                             in = ParameterIn.PATH,
                             required = true,
                             description = "Profile id - UUID or Scientific name"),
-                    @Parameter(name = "imageId",
+                    @Parameter(name = "fileName",
                             in = ParameterIn.PATH,
                             required = true,
-                            description = "Image id - UUID"),
+                            description = "fileName"),
                     @Parameter(name = "type",
                             in = ParameterIn.QUERY,
                             required = true,
@@ -623,10 +623,10 @@ class ApiController extends BaseController {
         forward controller: "profile", action: "getLocalImage"
     }
 
-    @Path("/api/opus/{opusId}/profile/{profileId}/image/thumbnail/{imageId}")
+    @Path("/api/opus/{opusId}/profile/{profileId}/image/thumbnail/{fileName}")
     @Operation(
             summary = "Get thumbnail image associated with a profile",
-            operationId = "/api/opus/{opusId}/profile/{profileId}/image/thumbnail/{imageId}",
+            operationId = "/api/opus/{opusId}/profile/{profileId}/image/thumbnail/{fileName}",
             method = "GET",
             responses = [
                     @ApiResponse(
@@ -661,10 +661,10 @@ class ApiController extends BaseController {
                             in = ParameterIn.PATH,
                             required = true,
                             description = "Profile id - UUID or Scientific name"),
-                    @Parameter(name = "imageId",
+                    @Parameter(name = "fileName",
                             in = ParameterIn.PATH,
                             required = true,
-                            description = "Image id - UUID"),
+                            description = "fileName"),
                     @Parameter(name = "type",
                             in = ParameterIn.QUERY,
                             required = true,

diff --git a/grails-app/controllers/au/org/ala/profile/hub/ProfileController.groovy b/grails-app/controllers/au/org/ala/profile/hub/ProfileController.groovy
@@ -409,9 +409,9 @@ class ProfileController extends BaseController {
                 ImageType type = params.type as ImageType
                 //NB this imageId param already has the file extension on it, really the file name on disk
                 if (type == ImageType.STAGED) {
-                    displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.imageId, true)
+                    displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.fileName, true)
                 } else if (type == ImageType.PRIVATE) {
-                    displayLocalImage("${grailsApplication.config.image.private.dir}/", params.opusId, params.profileId, params.imageId, true)
+                    displayLocalImage("${grailsApplication.config.image.private.dir}/", params.opusId, params.profileId, params.fileName, true)
                 }
             } catch (IllegalArgumentException e) {
                 log.warn(e)
@@ -428,9 +428,9 @@ class ProfileController extends BaseController {
                 ImageType type = params.type as ImageType
                 //NB this imageId param already has the file extension on it, really the file name on disk
                 if (type == ImageType.STAGED) {
-                    displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.imageId, false)
+                    displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.fileName, false)
                 } else if (type == ImageType.PRIVATE) {
-                    displayLocalImage("${grailsApplication.config.image.private.dir}/", params.opusId, params.profileId, params.imageId, false)
+                    displayLocalImage("${grailsApplication.config.image.private.dir}/", params.opusId, params.profileId, params.fileName, false)
                 }
             } catch (IllegalArgumentException e) {
                 log.warn(e)

diff --git a/grails-app/controllers/au/org/ala/profile/hub/UrlMappings.groovy b/grails-app/controllers/au/org/ala/profile/hub/UrlMappings.groovy
@@ -264,8 +264,8 @@ class UrlMappings {
             get "/opus/$opusId/profile" (version: "1.0", controller: "api", action: "getProfiles", namespace: "v1")
             get "/opus/$opusId/profile/$profileId" (version: "1.0", controller: "api", action: "get", namespace: "v1")
             get "/opus/$opusId/profile/$profileId/image" (version: "1.0", controller: "api", action: "getImages", namespace: "v1")
-            get "/opus/$opusId/profile/$profileId/image/$imageId" (version: "1.0", controller: "api", action: "getLocalImage", namespace: "v1")
-            get "/opus/$opusId/profile/$profileId/image/thumbnail/$imageId" (version: "1.0", controller: "api", action: "retrieveLocalThumbnailImage", namespace: "v1")
+            get "/opus/$opusId/profile/$profileId/image/$fileName" (version: "1.0", controller: "api", action: "getLocalImage", namespace: "v1")
+            get "/opus/$opusId/profile/$profileId/image/thumbnail/$fileName" (version: "1.0", controller: "api", action: "retrieveLocalThumbnailImage", namespace: "v1")
             get "/opus/$opusId/profile/$profileId/attribute/$attributeId" (version: "1.0", controller: "api", action: "getAttributes", namespace: "v1")
             get "/opus/$opusId/profile/$profileId/draft" (version: "1.0", controller: "api", action: "getDraftProfile", namespace: "v1")
             get "/opus" (version: "1.0", controller: "api", action: "getListCollections", namespace: "v1")