Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#781 #782

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Feature/#781 #782

merged 4 commits into from
Oct 13, 2023

Conversation

schoicsiro
Copy link
Contributor

Would you be able to get PR?

@schoicsiro schoicsiro requested a review from temi August 28, 2023 23:39
temi
temi requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@temi temi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, remove from URL mapping all the controller actions that has been deleted.

grails-app/views/profile/_layoutTabbed.gsp Outdated Show resolved Hide resolved
grails-app/views/profile/_publications.gsp Show resolved Hide resolved
grails-app/views/profile/edit.gsp Outdated Show resolved Hide resolved
grails-app/views/profile/edit.gsp Outdated Show resolved Hide resolved
grails-app/views/profile/show.gsp Outdated Show resolved Hide resolved
@schoicsiro schoicsiro requested a review from temi October 10, 2023 01:44
@temi temi merged commit 0103d97 into dev Oct 13, 2023
1 check passed
@temi temi deleted the feature/#781 branch October 13, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temi temi temi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schoicsiro @temi