#785_2 replace imageId to fileName #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoicsiro
changed the title
temi
requested changes
Nov 13, 2023
| @@ -409,9 +409,9 @@ class ProfileController extends BaseController { | |||
| ImageType type = params.type as ImageType | |||
| //NB this imageId param already has the file extension on it, really the file name on disk | |||
| if (type == ImageType.STAGED) { | |||
| displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.imageId, true) | |||
| displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.fileName, true) | |||
There was a problem hiding this comment.
do not rename this parameter. keep original. It is used by other parts of application.
| @@ -428,9 +428,9 @@ class ProfileController extends BaseController { | |||
| ImageType type = params.type as ImageType | |||
| //NB this imageId param already has the file extension on it, really the file name on disk | |||
| if (type == ImageType.STAGED) { | |||
| displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.imageId, false) | |||
| displayLocalImage("${grailsApplication.config.image.staging.dir}/", params.opusId, params.profileId, params.fileName, false) | |||
| @@ -623,10 +623,10 @@ class ApiController extends BaseController { | |||
| forward controller: "profile", action: "getLocalImage" | |||
There was a problem hiding this comment.
make sure the value of fileName is assigned to parameter imageId since getLocalImage action still uses imageId
| in = ParameterIn.PATH, | ||
| required = true, | ||
| description = "Image id - UUID"), | ||
| description = "fileName"), |
There was a problem hiding this comment.
make sure the value of fileName is assigned to parameter imageId since retrieveLocalThumbnailImage action still uses imageId
temi
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you be able to get PR?