-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#744 #34
Feature/#744 #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Please fix failing tests.
All test cases are ok when I run test in my local because I changed attribute.text with index and reindexed |
I fixed test cases without calling elastic search |
|
||
then: | ||
qMap.findAll(it -> it.toString().contains("dilan")) != null | ||
result.find { it.contains(profile1.scientificName) } != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not think result, profile1 or opus1 is needed. remove them.
} | ||
|
||
qMap.findAll(it -> it.toString().contains(searchItem)) != null | ||
result && isFind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here result, profile, attributes are not needed. remove them. Only testing on qMap is needed.
Would you be able to get PR?