Allow using a fixed locale as a workaround for issues with number formatting when adding layers #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevent issues with number formatting in some others.
… prevent issues with number formatting when adding layers. AtlasOfLivingAustralia#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using nl-be locale we encountered problems when adding layers.
Because of the difference in number formatting (thousands and decimal separators), the bounding box numbers would be out-of-whack when adding layers.
This is a simple workaround that should prevent these issues by allowing use to use a fixed locale, regardless of the user's choices made on the front-end.
Considering the spatial-service only serves admin pages and no real user-facing ones, this seems like a reasonable fix?