ytobi's aria2 fixes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue because the default image already comes with the package database.
Using `--lzma` on such a large binary is causing long loading times - not just when running, but also when examining the executable in the file explorer (potentially due to the virus scanner). With many of these compressed executables in the same folder, the CPU shoots up to 100% just examining them, before they are even run. There is not a dramatic difference between UCL and LZMA, anyway - 1 MB is a decent price to pay for significantly faster loading times.
This reverts commit 88bc4ef.
pass correct argument to the finished signal.
|
Revert 95a9f17 after merge |
oldmud0
requested changes
Jan 7, 2021
Comment on lines
+499
to
+504
| [&](short code) { | ||
| const QString file("Unknown file"); | ||
| error = true; | ||
| errorMsg = file; | ||
| errorCode = code; | ||
| qCritical() << "Error extracting" << file << "- code" << code; |
There was a problem hiding this comment.
The change in this signal's signature is due to a major version change in QArchive that apparently was applied to this branch. I would be careful because I have not tested that new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will need to change the url back but otherwise can confirm these work