Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairing Breaks Web. #146

Open
MartiniArtz opened this issue May 25, 2022 · 7 comments
Open

Pairing Breaks Web. #146

MartiniArtz opened this issue May 25, 2022 · 7 comments
Assignees

Comments

@MartiniArtz
Copy link

MartiniArtz commented May 25, 2022

When pairing, versions of the paired sprites appeared behind sprites that are not paired.
Screen Shot 2022-05-24 at 11 01 05 PM
In the attached photo is someone who does not have pairing on, yet my sprite still appears behind them, this same effect happened with several other people in the chatroom.

@caleb-mabry caleb-mabry self-assigned this Jul 17, 2022
@stonedDiscord
Copy link
Member

is there a specific setup on how to reproduce this
haven't seen it yet, except when 2 characters have the same name/share a folder

@AwesomeAim
Copy link
Contributor

AwesomeAim commented Feb 3, 2023

idk why web users don't care about their platform and don't reproduce their own issues
image
image
image
a pair partner in the same position as someone who is talking without a pair partner has them attached first image is the actual pairing, second and third are the pair partner appearing over other people talking without partners but having that partner attached to them. left is web and right is client if that wasn't obvious

@caleb-mabry
Copy link
Contributor

Thanks @AwesomeAim , I'll look into it tomorrow

@caleb-mabry
Copy link
Contributor

Just updating this because I'm taking a nap on this. Dug into this a little bit and it seems fine unless you're using an Akashi server

@stonedDiscord
Copy link
Member

the logic to parse the pairing information on the web side is not very complex and i can see plenty of paired characters on vanilla

@stonedDiscord
Copy link
Member

does akashi handle pairing different somehow @Salanto @in1tiate ?

@OmniTroid
Copy link
Contributor

I've seen this occasionally, but it's difficult to consistently reproduce. I've managed to reproduce another issue that may be related, where one of the chars speaking animation is replaced by the other's idle animation:
2023-11-30 20-48-46

Feels like we have some race conditions when it comes to handling pairing, need to take a hard look at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants